[PATCH] D125655: [HLSL] add -P option for dxc mode.

[Chris Bieneman via Phabricator via cfe-commits]

beanz added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:181
+    if (DAL->hasArg(options::OPT__SLASH_P))
+      getDriver().Diag(diag::warn_drv_dxc_ignore_output_for_preprocess) << "Fo";
+
----------------
python3kgae wrote:
> beanz wrote:
> > This warning should fire in CL mode too right? Should it not be dxc-specific?
> cl mode report this warning
> 
> 
> >     warning: b.txt: 'linker' input unused [-Wunused-command-line-argument]
> 
> 
> when input is
>   --driver-mode=cl -Fo b.txt  -P -Fi"a.txt"
> 
> For HLSL, both -Fo and -Fi should be output.
Then it shouldn’t be named `dxc` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125655/new/

https://reviews.llvm.org/D125655