[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 13 14:49:48 PDT 2022


tra added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:121
 
+    # Tests should not rely on a certain cuda device being available on the machine,
+    # or a certain version of it
----------------
The comment is incorrect. These flags have nothing to do with GPU availability, but rather with CUDA SDK which is normally expected to provide the 'standard' set of CUDA headers and libdevice bitcode.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cuda/unsafe-api-call-function-handler.cu:1
+// (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary.
+
----------------
This does not look right. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133804/new/

https://reviews.llvm.org/D133804



More information about the cfe-commits mailing list