[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

Sam James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 13 14:48:06 PDT 2022


thesamesam added a comment.

In D133375#3774293 <https://reviews.llvm.org/D133375#3774293>, @aaron.ballman wrote:

> So the basic idea here is that the default can be specified by a configuration file and thus we don't need any configure-time variable for it? But then why do we need other configuration macros like default stdlib or default linker? Mostly trying to understand what the rule of thumb is for when something should be a configure macro and when something should be left to a configuration file instead.

Also, until https://reviews.llvm.org/D109621 or similar is resolved, I don't feel like the actual need is addressed. Forcing distributions to use a prefixed Clang binary feels like a hack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133375/new/

https://reviews.llvm.org/D133375



More information about the cfe-commits mailing list