[PATCH] D133773: [clang] fix linker executable path in test

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

In D133773#3786611 <https://reviews.llvm.org/D133773#3786611>, @alvinhochun wrote:

> In D133773#3786602 <https://reviews.llvm.org/D133773#3786602>, @mstorsjo wrote:
>
>> In D133773#3786484 <https://reviews.llvm.org/D133773#3786484>, @alvinhochun wrote:
>>
>>> Ah sorry about that, I didn't realize the command includes `.exe` on Windows. (For the record, `ld"` matches both `ld` and `ld.lld`.)
>>
>> No, iirc these quotes are checked as literal part of the matched string here; otherwise the pattern `ld"` would match `ld.exe"` too. So to match any linker name, I'd write `ld{{.*}}"` or maybe something like `ld{{[\.a-z]*}}"`, modulo regex syntax.
>
> Oops, I meant `ld"` and `ld.lld"`, because both ends in `ld"`.

Oh, I see - that's very sneaky!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133773/new/

https://reviews.llvm.org/D133773