[PATCH] D133773: [clang] fix linker executable path in test

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 13 08:23:51 PDT 2022


mstorsjo added a comment.

In D133773#3786484 <https://reviews.llvm.org/D133773#3786484>, @alvinhochun wrote:

> Ah sorry about that, I didn't realize the command includes `.exe` on Windows. (For the record, `ld"` matches both `ld` and `ld.lld`.)

No, iirc these quotes are checked as literal part of the matched string here; otherwise the pattern `ld"` would match `ld.exe"` too. So to match any linker name, I'd write `ld{{.*}}"` or maybe something like `ld{{[\.a-z]*}}"`, modulo regex syntax.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133773/new/

https://reviews.llvm.org/D133773



More information about the cfe-commits mailing list