[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

[Tom Praschan via Phabricator via cfe-commits]

tom-anders added inline comments.


================
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:150-151
       clang::tooling::ArgumentsAdjuster(
-          clang::clangd::CommandMangler::detect()));
+          [Mangler = std::shared_ptr<clang::clangd::CommandMangler>(
+               clang::clangd::CommandMangler::detect().release())](
+              const std::vector<std::string> &Args, llvm::StringRef File) {
----------------
Just wondering, why do you need to convert to a shared_ptr here? Couldn't the lambda just take ownership of the unique_ptr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133756/new/

https://reviews.llvm.org/D133756