[PATCH] D133749: [clang][NFC] Update test case struct-union-BE.c for opaque-pointers

Ting Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 12 23:41:43 PDT 2022


tingwang created this revision.
tingwang added reviewers: dsanders, rjmccall, spetrovic, vkalintiris, john.brawn, petarj.
tingwang added a project: clang.
Herald added a project: All.
tingwang requested review of this revision.
Herald added a subscriber: cfe-commits.

Update patterns in this test case to align with opaque-pointers, otherwise it will not be able to catch errors.

This is spotted during https://reviews.llvm.org/D133338 investigation. During test after removed `!DirectTy->isStructTy()`, this test case still passed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133749

Files:
  clang/test/CodeGen/struct-union-BE.c


Index: clang/test/CodeGen/struct-union-BE.c
===================================================================
--- clang/test/CodeGen/struct-union-BE.c
+++ clang/test/CodeGen/struct-union-BE.c
@@ -22,9 +22,9 @@
   if (x.c !=  10)
     abort();
   va_end (ap);
-// MIPS-NOT: %{{[0-9]+}} = getelementptr inbounds i8, i8* %argp.cur, i32 3
-// MIPS64-NOT: %{{[0-9]+}} = getelementptr inbounds i8, i8* %argp.cur, i64 7
-// ARM-NOT: %{{[0-9]+}} = getelementptr inbounds i8, i8* %argp.cur, i32 3
+// MIPS-NOT: %{{[0-9]+}} = getelementptr inbounds i8, ptr %argp.cur, i32 3
+// MIPS64-NOT: %{{[0-9]+}} = getelementptr inbounds i8, ptr %argp.cur, i64 7
+// ARM-NOT: %{{[0-9]+}} = getelementptr inbounds i8, ptr %argp.cur, i32 3
 }
 
 void funi(int n, ...) {
@@ -35,9 +35,9 @@
   if (x.c !=  10)
     abort();
   va_end (ap);
-// MIPS-NOT: %{{[0-9]+}} = getelementptr inbounds i8, i8* %argp.cur, i32 3
-// MIPS64-NOT: %{{[0-9]+}} = getelementptr inbounds i8, i8* %argp.cur, i64 7
-// ARM-NOT: %{{[0-9]+}} = getelementptr inbounds i8, i8* %argp.cur, i32 3
+// MIPS-NOT: %{{[0-9]+}} = getelementptr inbounds i8, ptr %argp.cur, i32 3
+// MIPS64-NOT: %{{[0-9]+}} = getelementptr inbounds i8, ptr %argp.cur, i64 7
+// ARM-NOT: %{{[0-9]+}} = getelementptr inbounds i8, ptr %argp.cur, i32 3
 }
 
 void foo(void) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133749.459653.patch
Type: text/x-patch
Size: 1297 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220913/63fe1ba6/attachment.bin>


More information about the cfe-commits mailing list