[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.h:58
+  llvm::SmallVector<BitCodeLibraryInfo, 12>
+  getHIPDeviceLibs(const llvm::opt::ArgList &Args) const override;
+
----------------
jhuber6 wrote:
> JonChesterfield wrote:
> > Why hip device libs? There's a common set, plus a hip.bc plus a opencl.bc. I'd expect us to want only the common set. Hip.bc shouldn't have non-hip stuff in it.
> Existing virtual function, just re-used it.
Rename it rocm perhaps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133726/new/

https://reviews.llvm.org/D133726