[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

[Fangrui Song via Phabricator via cfe-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1116
+    if (GV->hasDLLExportStorageClass()) {
+      // Reject explicit hidden visibility on dllexport.
+      if (LV.getVisibility() == HiddenVisibility)
----------------
bd1976llvm wrote:
> Opinion: I don't think these comments are needed as the code is clear. I think it would be better to have a single comment at the top of this block e.g. "Reject incompatible dlllstorageclass and visibility annotations" or just remove them.
Will change. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133266/new/

https://reviews.llvm.org/D133266