[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/Format.cpp:1965
             (Style.JavaScriptQuotes == FormatStyle::JSQS_Double &&
-             !Input.startswith("\'"))) {
+             !Input.startswith("\'")))
           continue;
----------------
These braces should stay, shouldn't they?


================
Comment at: clang/lib/Format/Format.cpp:2190
               Matching->is(TT_ArrayInitializerLSquare)) &&
-            !(FormatTok->is(tok::r_brace) && Matching->is(TT_DictLiteral))) {
+            !(FormatTok->is(tok::r_brace) && Matching->is(TT_DictLiteral)))
           continue;
----------------
It seems like there are a ton of unrelated brace removals.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133589/new/

https://reviews.llvm.org/D133589