[PATCH] D133622: [clang][test] Disallow using the default module cache path in lit tests

Mon Sep 12 13:18:31 PDT 2022

benlangmuir added a comment.

Reverted due to failure on a bot https://lab.llvm.org/buildbot/#/builders/214/builds/3252

I'm not sure how to deal with missing `env -u`.

- We could do `env CLANG_MODULE_CACHE_PATH=` and change the compiler's interpretation of empty string for this variable. I'm not sure if the current behaviour (there will be no module cache in the cc1 at all) is intentional or useful.  Hesitant to change this behaviour.
- We could try to enumerate all the environments that don't support `env -u` and disable these two tests on  those platforms.  So far it was just one AIX bot, but I wouldn't be surprised if other less commonly used unixes have the same issue.
- We could make the command inscrutable, like `not env -u X true || env -u ... real command ...` so that if `env -u X true` fails (presumably due to not supporting `-u` option) we won't run the rest of the RUN line.

If someone has a suggestion for a simple fix, I can try again.  But otherwise I doubt it's worth putting much time into this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133622/new/

https://reviews.llvm.org/D133622