[PATCH] D133705: [HIP] Fix unbundling archive

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 12 10:08:46 PDT 2022


yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1959
+      if (FoundAOB)
+        break;
     }
----------------
scchan wrote:
> The AOBFileNames small vector needs to be cleared if !FoundAOB or just move its declaration into the LibraryPaths loop.
> The AOBFileNames small vector needs to be cleared if !FoundAOB or just move its declaration into the LibraryPaths loop.

will move the decl into LibraryPaths loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133705/new/

https://reviews.llvm.org/D133705



More information about the cfe-commits mailing list