[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

[Yusuke Kadowaki via Phabricator via cfe-commits]

yusuke-kadowaki marked 2 inline comments as done.
yusuke-kadowaki added a comment.

So other than the naming, does the struct look good?



================
Comment at: clang/include/clang/Format/Format.h:406
+    /// Specifies the way to align trailing comments
+    TrailingCommentsAlignmentKinds Kind;
+    /// How many empty lines to apply alignment
----------------
MyDeveloperDay wrote:
> Kind? doesn't feel like the right word
What do you recommend?


================
Comment at: clang/include/clang/Format/Format.h:428-433
+    bool operator==(const TrailingCommentsAlignmentStyle &R) const {
+      return Kind == R.Kind && OverEmptyLines == R.OverEmptyLines;
+    }
+    bool operator!=(const TrailingCommentsAlignmentStyle &R) const {
+      return !(*this == R);
+    }
----------------
MyDeveloperDay wrote:
> yusuke-kadowaki wrote:
> > > I don't understand the need for state as a struct could have multiple options (as enums) each enum should have a state that means "Leave"
> > 
> > @MyDeveloperDay 
> > Without having state, how can this be implemented?
> bool Enabled  =  (Kind != FormatStyle::TCAS_Leave)
Oh ok so I think we are on the same page.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132131/new/

https://reviews.llvm.org/D132131