[PATCH] D133518: [HLSL] Call global destructors from entries

Sat Sep 10 05:22:38 PDT 2022

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D133518#3781308 <https://reviews.llvm.org/D133518#3781308>, @beanz wrote:

> In D133518#3781101 <https://reviews.llvm.org/D133518#3781101>, @aaron.ballman wrote:
>
>> This generally LGTM, but to double-check: the behavior if the user does call `atexit()` or or `at_quick_exit()` is that we simply don't call those handlers? As opposed to something worse like we dispatch to the handler and then crash on exit or something like that?
>
> There should be no way to successfully compile and link a shader calling `atexit()` or `at_quick_exit()`. Neither of those functions are provided by the runtime so it should turn into a compile or linking error somewhere in the build process (either missing declaration or missing symbol resolution).

Wonderful! Then this LGTM!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133518/new/

https://reviews.llvm.org/D133518