[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

[Dave MacLachlan via Phabricator via cfe-commits]

dmaclach added a comment.

Thanks Puyan! Awesome to see this moving forward.



================
Comment at: clang/test/CodeGenObjC/objc-direct-wrapper.m:30
+#if ENABLE_VISIBLE_OBJC_DIRECT
+#define OBJC_DIRECT __attribute((objc_direct)) __attribute__((objc_direct_visible))
+#else
----------------
This is the case that mwyman described above where we would prefer to only have the single attribute correct?


================
Comment at: clang/test/CodeGenObjC/objc-direct-wrapper.m:35
+
+ at interface C
+- (void)testMethod:(int)arg1 bar:(float)arg2 OBJC_DIRECT;
----------------
I'd like to see a test for the protocol case for coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86049/new/

https://reviews.llvm.org/D86049