[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

Xiang Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 9 16:19:21 PDT 2022


python3kgae added a comment.

In D132913#3781611 <https://reviews.llvm.org/D132913#3781611>, @python3kgae wrote:

> In D132913#3781591 <https://reviews.llvm.org/D132913#3781591>, @chapuni wrote:
>
>> The fix looks good. Thanks.
>>
>>> Is -DLLVM_ENABLE_ASSERTIONS=ON what you mean by -Asserts?
>>
>> Oh excuse me, "-Asserts" was an ancient term, "w/o assertsions" in the autoconf age.
>> An antonym was "+Asserts". it means `LLVM_ENABLE_ASSERTIONS=ON`
>
> I see. I'll test LLVM_ENABLE_ASSERTIONS=OFF this time.

Confirmed pass with LLVM_ENABLE_ASSERTIONS=OFF


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132913/new/

https://reviews.llvm.org/D132913



More information about the cfe-commits mailing list