[PATCH] D133574: [C2x] reject type definitions in offsetof

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 9 12:36:53 PDT 2022


aaron.ballman added a comment.

Thank you for working on this! This approach can work (though I would recommend using an RAII object akin to `InMessageExpressionRAIIObject`), but have you explored making a new `DeclSpecContext` and modifying `isDefiningTypeSpecifierContext()`? I think that would likely be a cleaner approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133574/new/

https://reviews.llvm.org/D133574



More information about the cfe-commits mailing list