[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

Fri Sep 9 11:11:08 PDT 2022

MaskRay added a comment.

In D131465#3780833 <https://reviews.llvm.org/D131465#3780833>, @AaronLiu wrote:

> In D131465#3780767 <https://reviews.llvm.org/D131465#3780767>, @aaron.ballman wrote:
>
>> In D131465#3780717 <https://reviews.llvm.org/D131465#3780717>, @AaronLiu wrote:
>>
>>> This cause a large amount failures in our testing with errors such as:
>>>
>>>   error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
>>>
>>>   error: ISO C++17 does not allow dynamic exception specifications [-Wdynamic-exception-spec]
>>
>> Sorry to hear that. Who is "our" in this case and do you have a suggestion for how you'd like to proceed?
>
> Some down stream regression tests.

I don't think this is qualified as a request for revert. Isn't it a matter of add -std=gnu++14 to your project?
See my previous comment about a target maintainer's request if your downstream project is related to a target which for some reasons want to stick with gnu++14.

> I see the above comments:
>
>> I've reverted this change because it causes major llvm-test-suite breakage.
>
> Probably currently this is the best way.
> Thanks!

I disagree. The issue was fixed on llvm-test-suite by pinning projects to 14. They previously used the implicit default.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131465/new/

https://reviews.llvm.org/D131465