[PATCH] D133194: rewording note note_constexpr_invalid_cast

[Muhammad Usman Shahid via Phabricator via cfe-commits]

Codesbyusman added inline comments.


================
Comment at: clang/test/Sema/cast.c:2
 // RUN: %clang_cc1 -fsyntax-only -triple x86_64-unknown-unknown %s -verify
+// RUN: %clang_cc1 -std=c99 -fsyntax-only -DConstantCast -Wvla -verify %s 
+
----------------
aaron.ballman wrote:
> Instead of adding this RUN line, I think you can modify the previous RUN line to add `-Wvla`, and skip the `#ifdef` entirely.
> 
> The reason this test is passing for you locally but failing on the server is because this RUN line is missing a triple and there are parts of the test which are sensitive to the target architecture.
> Instead of adding this RUN line, I think you can modify the previous RUN line to add `-Wvla`, and skip the `#ifdef` entirely.
> 
> The reason this test is passing for you locally but failing on the server is because this RUN line is missing a triple and there are parts of the test which are sensitive to the target architecture.

ok, Thank you


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133194/new/

https://reviews.llvm.org/D133194