[PATCH] D132421: [HLSL] Support PCH for cc1 mode

[Chris Bieneman via Phabricator via cfe-commits]

beanz added inline comments.


================
Comment at: clang/lib/Frontend/FrontendAction.cpp:1036
+        // Only add HLSLSema when not in MultiSource.
+        if (!MultiSource->HasSource<ExternalSemaSource>())
+          MultiSource->AddSource(HLSLSema.get());
----------------
This seems off. The multi source should always have at least two external sema sources.

Is there any situation where the HLSL sema would already be added?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132421/new/

https://reviews.llvm.org/D132421