[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

Fri Sep 9 08:57:32 PDT 2022

dblaikie added a comment.

In D133354#3779882 <https://reviews.llvm.org/D133354#3779882>, @ningvin wrote:

> In D133354#3779123 <https://reviews.llvm.org/D133354#3779123>, @dblaikie wrote:
>
>> That works, you can also take the hash with the `rG` prefix and use that: rGd577fbbd1c9d6dab193d530fcd807efc3b3bc9ad <https://reviews.llvm.org/rGd577fbbd1c9d6dab193d530fcd807efc3b3bc9ad> and that works too.
>
> Didn't know that, thanks!
>
> In D133354#3779765 <https://reviews.llvm.org/D133354#3779765>, @hans wrote:
>
>> For more context, this was initially raised in https://discourse.llvm.org/t/why-is-the-deprecated-copy-warning-suppressed-in-msvc-compatibility-mode/65085/1
>
> Oh yes sorry, I should have linked to that.

ah, *thumbs up* then, though I'll probably leave it to @hansw to review so he's aware of when this goes in/will have context in case any fallout is observed on the Windows side of things

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133354/new/

https://reviews.llvm.org/D133354