[PATCH] D133570: #57353 on github

Fri Sep 9 06:45:54 PDT 2022

aaron.ballman added reviewers: rjmccall, efriedma.
aaron.ballman added a comment.

In D133570#3779856 <https://reviews.llvm.org/D133570#3779856>, @OfekShochat wrote:

> its my first time contributing. this is probably very bad and goes against a lot of guidelines, but I wouldnt resist to fix this

Welcome, and thank you for the patch! I'm going to add a few more reviewers who typically look at codegen changes, but I do have some high-level suggestions. Can you edit the title of the review (there's an "edit revision" link in the upper-right of the review) so that there's a short description of what is being fixed in the title? The title is what most reviewers see in our inbox/review list, so knowing what the patch is about helps reviewers immensely (also, we use the title of the review as the title of the commit message). Also, we ask that all changes to the code base come with test coverage showing what has been fixed, so please add some test coverage (most likely to `clang/test/CodeGen/`). Finally, we like to add information to our release notes about bug fixes so users know about the improvements, so please add a short release note (to clang/docs/ReleaseNotes.rst).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133570/new/

https://reviews.llvm.org/D133570