[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

Thu Sep 8 20:46:47 PDT 2022

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.

You may want to split the patch, with refactoring as the first, and the Mach-O specific change as the second one.

================
Comment at: clang/include/clang/Driver/ToolChain.h:111

+  enum UnwindTableLevel {
+    UTL_None,
----------------
I'd prefer `enum class` without the `UTL_` prefix. That will be more readable. `UTL` isn't very clear (`RM_Enabled` is kinda a bad name as without `RTTIMode` it's clear what's enabled; `UNW_CompilerRT` is fine as from CompilerRT/Libgcc we know it refers to the unwind or builtin library; Asynchrounous/Synchronous is not very clear).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131153/new/

https://reviews.llvm.org/D131153