[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

Thu Sep 8 19:21:44 PDT 2022

dblaikie added a comment.

In D133354#3778281 <https://reviews.llvm.org/D133354#3778281>, @ningvin wrote:

> In D133354#3778237 <https://reviews.llvm.org/D133354#3778237>, @dblaikie wrote:
>
>> Got any pointers to the commits/authors that added this functionality in the first place? (would be good to have any review history, etc, to check against the change here)
>
> That would be @rsmith if I am not mistaken

Ah, indeed - thanks for the context. (I almost thought it wasn't in that patch, because there was no mention of "MSVC" there - but I see now it was "MicrosoftMode" back then)

> with https://reviews.llvm.org/rGd577fbbd1c9d6dab193d530fcd807efc3b3bc9ad (not sure how to best link to commits/changes in phabricator).

That works, you can also take the hash with the `rG` prefix and use that: rGd577fbbd1c9d6dab193d530fcd807efc3b3bc9ad <https://reviews.llvm.org/rGd577fbbd1c9d6dab193d530fcd807efc3b3bc9ad> and that works too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133354/new/

https://reviews.llvm.org/D133354