[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

Thu Sep 8 14:47:47 PDT 2022

mizvekov added a comment.

In D133262#3778532 <https://reviews.llvm.org/D133262#3778532>, @royjacobson wrote:

> In D133262#3775375 <https://reviews.llvm.org/D133262#3775375>, @mizvekov wrote:
>
>> @royjacobson I decided to do a complete job here and fix all those issues except #54993. Can you confirm?
>>
>> I also applied the same idea to `type_pack_element` as I saw a crash related to that in the wild.
>
> That's amazing to hear, thanks for looking at it! I haven't had time to check it yet, but could you add the snippets from the bug reports as regression tests?

The snippets from the bug reports are using libc++ and std::make_integer_sequence directly, which we avoid in these kinds of regression tests, we tend to make very reduced test cases that compile standalone.

But I believe I included reductions that should show we fixed the same problem, unless I missed some specific case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133262/new/

https://reviews.llvm.org/D133262