[PATCH] D133339: [clangd] Isolate logic for setting LSPServer options
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 8 09:21:24 PDT 2022
kadircet updated this revision to Diff 458769.
kadircet added a comment.
I agree this is creating confusing state for constructors of ClangdLSPServer. It
would be interesting to create LSPServer after the initialize request one day.
- Make client-capability related options private again.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133339/new/
https://reviews.llvm.org/D133339
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdLSPServer.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133339.458769.patch
Type: text/x-patch
Size: 12022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220908/8ceb484c/attachment-0001.bin>
More information about the cfe-commits
mailing list