[PATCH] D127082: [clangd] Add Macro Expansion to Hover

Wed Sep 7 20:26:30 PDT 2022

vitalybuka added a comment.

897.65s: Clangd Unit Tests :: ./ClangdTests/25/72

In D127082#3776206 <https://reviews.llvm.org/D127082#3776206>, @daiyousei-qz wrote:

> In D127082#3776173 <https://reviews.llvm.org/D127082#3776173>, @vitalybuka wrote:
>
>> Looks like it breaks
>> https://lab.llvm.org/buildbot/#/builders/236/builds/206
>> https://lab.llvm.org/buildbot/#/builders/237/builds/85
>> https://lab.llvm.org/buildbot/#/builders/238/builds/103
>
> I take a quick look and it seems the failing tests were timed out. Considering the context of the change, I would guess it might be caused by some huge, nested macro being expanded. But it's weird since the expansion should only happen for Hover. Unfortunately, I don't have any aarch64 device to reproduce this locally and investigate further. Please feel free to reach out to me if there's anything I could help.

Actually it could be 72142fbac496a66769e16c80b076216d7c449ab2 <https://reviews.llvm.org/rG72142fbac496a66769e16c80b076216d7c449ab2> as well
@sammccall we may need to disable or revert broken tests

  After the patch:
  Slowest Tests:
  --------------------------------------------------------------------------
  897.65s: Clangd Unit Tests :: ./ClangdTests/25/72

  Before the patch 
  Slowest Tests:
  --------------------------------------------------------------------------
  157.84s: Clangd Unit Tests :: ./ClangdTests/DefineOutlineTest/QualifyReturnValue

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127082/new/

https://reviews.llvm.org/D127082