[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 7 14:10:05 PDT 2022


MaskRay added a comment.

In D131465#3774552 <https://reviews.llvm.org/D131465#3774552>, @sammccall wrote:

> In D131465#3774276 <https://reviews.llvm.org/D131465#3774276>, @aaron.ballman wrote:
>
>> In D131465#3772803 <https://reviews.llvm.org/D131465#3772803>, @MaskRay wrote:
>>
>>> Update clang-tools-extra/clangd/unittests/SelectionTests.cpp @sammccall
>>
>> This one looks to still be failing on Windows according to precommit CI.
>
> I've improved the test and pinned it to C++17 in 8af74da5bdbdccf13de84a4610ef75cd3dbac09e <https://reviews.llvm.org/rG8af74da5bdbdccf13de84a4610ef75cd3dbac09e>, you can just revert the changes to it in this patch.
> (Sorry for the conflict, but seemed better than Ray having to debug windows-only failures)

Thanks:) I'll revert this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131465/new/

https://reviews.llvm.org/D131465



More information about the cfe-commits mailing list