[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass
Thorsten via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 7 11:10:46 PDT 2022
tschuett added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:29
+
+namespace {
+
----------------
I believe you are going too far with the anonymous namespace. There is no need for static functions in anonymous namespaces.
https://llvm.org/docs/CodingStandards.html#anonymous-namespaces
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133392/new/
https://reviews.llvm.org/D133392
More information about the cfe-commits
mailing list