[PATCH] D133423: [clangd] Improve Selection testcase, pin to C++17

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

can you wait for premerge checks to finish (especially for windows)?



================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:729-730
   EXPECT_EQ("CXXConstructExpr", nodeKind(Str->Parent->Parent));
-  EXPECT_EQ(Str, &Str->Parent->Parent->ignoreImplicit())
-      << "Didn't unwrap " << nodeKind(&Str->Parent->Parent->ignoreImplicit());
+  EXPECT_EQ("ImplicitCastExpr", nodeKind(Str->Parent->Parent->Parent));
+  const SelectionTree::Node *ICE = Str->Parent->Parent->Parent;
+  EXPECT_EQ("CallExpr", nodeKind(ICE->Parent));
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133423/new/

https://reviews.llvm.org/D133423