[PATCH] D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

Tomas Matheson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 7 02:40:05 PDT 2022


tmatheson added inline comments.


================
Comment at: clang/lib/Headers/arm_acle.h:219
 __revsh(int16_t __t) {
-  return __builtin_bswap16(__t);
+  return (int16_t)__builtin_bswap16((int16_t)__t);
 }
----------------
Should the second cast be (uint16_t)__t?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132003/new/

https://reviews.llvm.org/D132003



More information about the cfe-commits mailing list