[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 6 23:38:45 PDT 2022


mstorsjo added inline comments.


================
Comment at: clang/test/Driver/mingw-cfguard.c:1
+// RUN: %clang -v -target x86_64-w64-windows-gnu -### %s 2>&1 | FileCheck -check-prefixes=NO_CF,DEFAULT %s
+// RUN: %clang -v -target x86_64-w64-windows-gnu -### %s -mguard=none 2>&1 | FileCheck -check-prefixes=NO_CF,GUARD_NONE %s
----------------
MaskRay wrote:
> Use `--target=` for new tests (avoid legacy `-target `).
> 
> Omit unneeded `-v`.
The comment about preferring `--target=` over `-target` for new tests seems to be unaddressed here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132810/new/

https://reviews.llvm.org/D132810



More information about the cfe-commits mailing list