[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 6 20:03:36 PDT 2022


ChuanqiXu marked 2 inline comments as done.
ChuanqiXu added inline comments.


================
Comment at: clang/lib/CodeGen/CGCoroutine.cpp:688
+    auto &Context = getContext();
+    auto SizeTy = Context.getSizeType();
+    auto T = Builder.getIntNTy(Context.getTypeSize(SizeTy));
----------------
erichkeane wrote:
> Don't use 'auto' unless the RHS has the type in it clearly.  SO this should be QualType I think?  I also see you've broken that coding standard rule above.
Oh, sorry. I did move the code simply and didn't double check it. I've handled it in an separate NFC patch: https://github.com/llvm/llvm-project/commit/5f571eeb3f764c6d97b81822464ea420adef2cf7


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133341/new/

https://reviews.llvm.org/D133341



More information about the cfe-commits mailing list