[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 6 15:25:27 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Python 3.7 can use `subprocess.run` with `capture_output`: https://docs.python.org/3/library/subprocess.html#:~:text=capture_output

But llvm-project requires Python >= 3.6 now, so we have to stay with `Popen`. Technically `OSError` can be `FileNotFoundError` if you want to be more specific.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133358/new/

https://reviews.llvm.org/D133358



More information about the cfe-commits mailing list