[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 6 09:09:59 PDT 2022


jhuber6 updated this revision to Diff 458186.
jhuber6 added a comment.

Changing to `linkonce` linkage. According to the LLVM spec this should have the
expected behaviour where a single definition is kept at link-time for each
module. I tested this with a sample `HIP` program and it had the desired
behaviour. I could add a test attempting to show this if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130096/new/

https://reviews.llvm.org/D130096

Files:
  clang/lib/CodeGen/CodeGenModule.cpp
  clang/lib/CodeGen/TargetInfo.cpp
  clang/lib/CodeGen/TargetInfo.h
  clang/test/CodeGen/amdgcn-control-constants.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130096.458186.patch
Type: text/x-patch
Size: 9547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220906/274b9508/attachment-0001.bin>


More information about the cfe-commits mailing list