[PATCH] D133308: [cmake] do not set execution permission to regular files

[Sinan Lin via Phabricator via cfe-commits]

sinan created this revision.
sinan added reviewers: MaskRay, phosek, DavidSpickett.
Herald added subscribers: StephenFan, whisperity, mgorny.
Herald added a reviewer: NoQ.
Herald added a project: All.
sinan requested review of this revision.
Herald added projects: clang, clang-tools-extra.
Herald added a subscriber: cfe-commits.

some regular files(e.g. files that have no shebang and no execute bit in source dir) are wrongly assigned execution permission through cmake install, such as scanview.css and ear.c from libscanbuild, which is unnecessary and introduces warnings in some platforms:

install(PROGRAMS ...) is identical to the install(FILES ...) except that the default permissions for the installed file also include OWNER_EXECUTE, GROUP_EXECUTE, and WORLD_EXECUTE. (https://cmake.org/cmake/help/latest/command/install.html#installing-files)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133308

Files:
  clang-tools-extra/clang-include-fixer/tool/CMakeLists.txt
  clang/CMakeLists.txt
  clang/tools/clang-format/CMakeLists.txt
  clang/tools/clang-rename/CMakeLists.txt
  clang/tools/scan-build-py/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133308.458004.patch
Type: text/x-patch
Size: 4181 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220905/286d51ae/attachment-0001.bin>