[PATCH] D133299: [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.
Utkarsh Saxena via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 5 06:23:01 PDT 2022
usaxena95 accepted this revision.
usaxena95 added a comment.
This revision is now accepted and ready to land.
Thanks. Sorry I missed this.
================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:487-497
{
// Switch caller's context with LSPServer's background context. Since we
// rather want to propagate information from LSPServer's context into the
// Server, CDB, etc.
WithContext MainContext(BackgroundContext.clone());
llvm::Optional<WithContextValue> WithOffsetEncoding;
if (Opts.Encoding)
----------------
I think we should do this after the Opts has been fully set to avoid the confusion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133299/new/
https://reviews.llvm.org/D133299
More information about the cfe-commits
mailing list