[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

Mon Sep 5 06:07:31 PDT 2022

yusuke-kadowaki marked an inline comment as done.
yusuke-kadowaki added a comment.

Can we all agree with the decision whether we use the `AlignConsecutiveStyle` or introduce a new struct before I start implementing or updating the document?
IMO, both are reasonable in some respects so I'd like you owners to decide.

> Please also mark the comments as done once addressed so we know you’ve read and fixed our requests

I'm reading all the comments but  leaving some comments not done on purpose that I think the discussion is not done. Isn't it a right thing to do here?

================
Comment at: clang/include/clang/Format/Format.h:298
+  /// Style of aligning consecutive trailing comments.
+  /// This option existed as ``AlignTrailingComments`` since version 3.7.
+  ///
----------------
MyDeveloperDay wrote:
> Isn’t this completely wrong?
Could you please be more specific about why you think so when pointing out something? I don't see why you think it's wrong. I also would like to mention that I followed @HazardyKnusperkeks's request on this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132131/new/

https://reviews.llvm.org/D132131