[PATCH] D132192: [RISCV] Add '32bit' feature to rv32 only builtins.

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 4 20:21:50 PDT 2022


craig.topper added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:4359
-    return Diag(TheCall->getCallee()->getBeginLoc(),
-                diag::err_32_bit_builtin_64_bit_tgt);
-
----------------
luismarques wrote:
> That tablegen def is still being used for X86. Maybe you could make a similar patch for X86?
There's no "32bit" feature in X86.td in the backend. This was possible for RISC-V because I added "32bit" when I refactored mtune recently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132192/new/

https://reviews.llvm.org/D132192



More information about the cfe-commits mailing list