[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 3 20:57:58 PDT 2022


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146
+
+  The check now skips containers that are defined in the option IgnoredContainers.  The default value is ::std::array.
+
----------------
Please highlight option name and value with single back-tick.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1
-// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- -- -fno-delayed-template-parsing
+// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- -config="{CheckOptions: [{key: readability-container-data-pointer.IgnoredContainers, value: '::arrayType'}]}" -- -fno-delayed-template-parsing
 
----------------
I think test should be separated to handle situations with and without option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133244/new/

https://reviews.llvm.org/D133244



More information about the cfe-commits mailing list