[PATCH] D132998: [clang-tidy] Restrict use-equals-default to c++11-or-later
Alexander Shaposhnikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 2 15:19:55 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rG47dbacbc8ae2: [clang-tidy] Restrict use-equals-default to c++11-or-later (authored by alexander-shaposhnikov).
Changed prior to commit:
https://reviews.llvm.org/D132998?vs=456876&id=457715#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132998/new/
https://reviews.llvm.org/D132998
Files:
clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.h
clang-tools-extra/docs/ReleaseNotes.rst
clang-tools-extra/test/clang-tidy/checkers/modernize/use-equals-default-cxx98.cpp
Index: clang-tools-extra/test/clang-tidy/checkers/modernize/use-equals-default-cxx98.cpp
===================================================================
--- /dev/null
+++ clang-tools-extra/test/clang-tidy/checkers/modernize/use-equals-default-cxx98.cpp
@@ -0,0 +1,8 @@
+// RUN: %check_clang_tidy -std=c++98 %s modernize-use-equals-default %t
+
+struct S {
+ S() {}
+ // CHECK-FIXES: S() {}
+ ~S() {}
+ // CHECK-FIXES: ~S() {}
+};
Index: clang-tools-extra/docs/ReleaseNotes.rst
===================================================================
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -145,7 +145,7 @@
check.
The check now skips unions since in this case a default constructor with empty body
- is not equivalent to the explicitly defaulted one.
+ is not equivalent to the explicitly defaulted one. The check is restricted to c++11-or-later.
Removed checks
^^^^^^^^^^^^^^
Index: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.h
===================================================================
--- clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.h
+++ clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.h
@@ -38,7 +38,7 @@
public:
UseEqualsDefaultCheck(StringRef Name, ClangTidyContext *Context);
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
- return LangOpts.CPlusPlus;
+ return LangOpts.CPlusPlus11;
}
void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132998.457715.patch
Type: text/x-patch
Size: 1601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220902/daeee09b/attachment.bin>
More information about the cfe-commits
mailing list