[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

Fri Sep 2 12:59:03 PDT 2022

akyrtzi added a comment.

In D132801#3761253 <https://reviews.llvm.org/D132801#3761253>, @akyrtzi wrote:

> In D132801#3760014 <https://reviews.llvm.org/D132801#3760014>, @rsmith wrote:
>
>> This doesn't look right to me -- we still use module maps when modules are disabled to enforce layering checking, and when `-fmodules-local-submodule-visibility` is enabled but `-fmodules` is disabled we'll use them to provide modular semantics without pre-building modules. I'm going to revert.
>
> Sorry, I wasn't aware of that. Could `-fmodule-map-file=` be pruned out when `-fmodules-local-submodule-visibility` or `-fmodules-decluse` are not enabled?

I've opened https://reviews.llvm.org/D133229 for your consideration, let me know whether this addresses your concerns 🙏

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132801/new/

https://reviews.llvm.org/D132801