[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

The changes look reasonable to me, though if you think the flag is a temporary one, we might want to consider changes to document that explicitly.



================
Comment at: clang/docs/ReleaseNotes.rst:126
+  <https://clang.llvm.org/docs/Modules.html#use-declaration>`_ are now
+  diagnosed even when the includer is a textual header.
 
----------------
You should mention `-fno-modules-validate-textual-header-includes` here so that users know there's a transition flag available. Do you expect we'd like to remove that flag in the future, or do you expect we'll need to carry it around "forever"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132779/new/

https://reviews.llvm.org/D132779