[PATCH] D131268: [HLSL] Generate buffer subscript operators
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 2 10:26:12 PDT 2022
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a nit that was missed. Thanks for switching to static_cast, that makes me happier. :-)
================
Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:109
+ if (Template) {
+ if (const auto TTD = dyn_cast<TemplateTypeParmDecl>(
+ Template->getTemplateParameters()->getParam(0)))
----------------
Missed from the previous suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131268/new/
https://reviews.llvm.org/D131268
More information about the cfe-commits
mailing list