[PATCH] D133180: [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 1 22:42:08 PDT 2022


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

This LGTM, but one question about the test. Thanks!



================
Comment at: clang/test/CodeGenCXX/dllstorage-hidden.cpp:3
+
+// RUN: %clang_cc1 -triple x86_64-windows-msvc -fms-extensions -emit-llvm -fvisibility-inlines-hidden -o - %s | FileCheck %s --check-prefix=MSVC
+// RUN: %clang_cc1 -triple x86_64-windows-gnu -fms-extensions -emit-llvm -fvisibility-inlines-hidden -o - %s | FileCheck %s --check-prefix=GNU
----------------
What parts of this test requires `-fms-extensions`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133180/new/

https://reviews.llvm.org/D133180



More information about the cfe-commits mailing list