[PATCH] D131858: [clang] Track the templated entity in type substitution.
Matheus Izvekov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 1 19:57:08 PDT 2022
mizvekov added inline comments.
================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626
+ VisitDeclaratorDecl(D);
+ Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName());
+ Record.push_back(D->getIdentifierNamespace());
+
----------------
ChuanqiXu wrote:
> I still don't get the reason for the move. What's the benefit? Or why is it necessary?
Yeah, now the type can reference the template decl, so without moving this, it can happen during import of the type that we try to read this function template bits without having imported them yet.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131858/new/
https://reviews.llvm.org/D131858
More information about the cfe-commits
mailing list