[PATCH] D133066: fix a typo in comment of AddConversionCandidate
zhouyizhou via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 1 15:36:38 PDT 2022
zhouyizhou added a comment.
In D133066#3764384 <https://reviews.llvm.org/D133066#3764384>, @aaron.ballman wrote:
> The existing comment is correct according to my copy of the C++11 standard, but the standard has changed since C++11 and those words no longer appear in http://eel.is/c++draft/dcl.init.ref#5. Some more investigation is needed, but I suspect the correct action to take here is to update the comment based on the current standards wording or to see if there's a bug because the code does not match the comment.
thank Aaron for review my patch,
I am a passionate beginner,
this is a very good learning experience for me ;-) I am looking forward to seeing the final change.
Thanks again
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133066/new/
https://reviews.llvm.org/D133066
More information about the cfe-commits
mailing list