[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 1 14:45:41 PDT 2022


aprantl added inline comments.


================
Comment at: clang/include/clang/Sema/MultiplexExternalSemaSource.h:53
   ///
-  MultiplexExternalSemaSource(ExternalSemaSource& s1, ExternalSemaSource& s2);
+  MultiplexExternalSemaSource(ExternalSemaSource* S1, ExternalSemaSource* S2);
 
----------------
why this change? Does `&` imply ownership in our coding style?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133158/new/

https://reviews.llvm.org/D133158



More information about the cfe-commits mailing list