[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 1 13:40:26 PDT 2022


jhuber6 added inline comments.


================
Comment at: clang/test/Driver/cuda-bindings.cu:99
+// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output: (nothing)
 //
 // Test two gpu architectures up to the assemble phase.
----------------
tra wrote:
> tra wrote:
> > yaxunl wrote:
> > > should we check there is no binding for Assembler and Linker?
> > @jhuber6 : Interestingly enough, this exposed what looks like an issue with the new driver -- it will apparently attempt to run linker on empty inputs.
> > I believe it's an issue independent of this patch and will need to be fixed separately.
> > 
> > ```
> > bin/clang -target powerpc64le-ibm-linux-gnu -ccc-print-bindings -fsyntax-only --cuda-gpu-arch=sm_30 --cuda-gpu-arch=sm_35 --offload-new-driver /usr/local/google/home/tra/work/llvm/repo/clang/test/Driver/cuda-bindings.cu
> > # "nvptx64-nvidia-cuda" - "clang", inputs: ["clang/test/Driver/cuda-bindings.cu"], output: (nothing)
> > # "nvptx64-nvidia-cuda" - "clang", inputs: ["clang/test/Driver/cuda-bindings.cu"], output: (nothing)
> > # "nvptx64-nvidia-cuda" - "NVPTX::Linker", inputs: [(nothing), (nothing)], output: "/tmp/cuda-bindings-0bbbdf.fatbin"
> > # "powerpc64le-ibm-linux-gnu" - "clang", inputs: ["clang/test/Driver/cuda-bindings.cu", "/tmp/cuda-bindings-0bbbdf.fatbin"], output: (nothing)
> > ```
> -fsyntax-only indeed crashes the new driver: https://godbolt.org/z/vqs4b8Mv1
Yeah it seems to be because we don't quit when there's a `TY_Nothing` output. The expected behaviour of `fsyntax-only` should have no output, but we use the output from some previous phases when we build. Will need to find a way to still run both the host and device phases without input.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133133/new/

https://reviews.llvm.org/D133133



More information about the cfe-commits mailing list