[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

I don't mind the idea, but wonder if some level of RFC/project-wide decision should be made here?  WDYT @aaron.ballman ?



================
Comment at: clang/lib/Driver/Driver.cpp:5425
   Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir);
-  if (CCGenDiagnostics && A) {
-    SmallString<128> CrashDirectory(A->getValue());
+  const char *CrashDirectory = CCGenDiagnostics && A
+                                   ? A->getValue()
----------------
`StringRef` would be better here instead, which should mean you don't have to create the SmallString below, and could just work in `Twine`s for everything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133082/new/

https://reviews.llvm.org/D133082